Skip to content

Add video progress bar#46

Merged
flimshaw merged 1 commit intoflimshaw:masterfrom
GuillaumeGomez:progress-bar
Aug 26, 2016
Merged

Add video progress bar#46
flimshaw merged 1 commit intoflimshaw:masterfrom
GuillaumeGomez:progress-bar

Conversation

@GuillaumeGomez
Copy link
Contributor

However, it misses the css changes which follows:

.valiant-progress-bar {
    width: 100%;
    height: 8px;
    overflow: hidden;
}
.valiant-progress-bar:hover {
    cursor: pointer;
}
.valiant-progress-bar > div {
    height: 100%;
    float:left;
    background-color: #444;
}
.valiant-progress-bar > div:first-child {
    background-color: red;
}

for the simple reason that I have absolutely no clue where to find this file in here.

Fixes #30.

@flimshaw
Copy link
Owner

Thanks for this! i'll take a look this evening

@flimshaw flimshaw merged commit 97fb528 into flimshaw:master Aug 26, 2016
@GuillaumeGomez GuillaumeGomez deleted the progress-bar branch August 26, 2016 13:03
@GuillaumeGomez
Copy link
Contributor Author

What will happen to the css?

@flimshaw
Copy link
Owner

I merged it into the main .less file that holds it, and made a few minor tweaks. Thanks again, it's live on https://flimshaw.github.io/Valiant360/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants