Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video progress bar #46

Merged
merged 1 commit into from Aug 26, 2016
Merged

Add video progress bar #46

merged 1 commit into from Aug 26, 2016

Conversation

@GuillaumeGomez
Copy link
Contributor

GuillaumeGomez commented Aug 21, 2016

However, it misses the css changes which follows:

.valiant-progress-bar {
    width: 100%;
    height: 8px;
    overflow: hidden;
}
.valiant-progress-bar:hover {
    cursor: pointer;
}
.valiant-progress-bar > div {
    height: 100%;
    float:left;
    background-color: #444;
}
.valiant-progress-bar > div:first-child {
    background-color: red;
}

for the simple reason that I have absolutely no clue where to find this file in here.

Fixes #30.

@flimshaw
Copy link
Owner

flimshaw commented Aug 25, 2016

Thanks for this! i'll take a look this evening

@flimshaw flimshaw merged commit 97fb528 into flimshaw:master Aug 26, 2016
@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:progress-bar branch Aug 26, 2016
@GuillaumeGomez
Copy link
Contributor Author

GuillaumeGomez commented Aug 26, 2016

What will happen to the css?

@flimshaw
Copy link
Owner

flimshaw commented Aug 26, 2016

I merged it into the main .less file that holds it, and made a few minor tweaks. Thanks again, it's live on https://flimshaw.github.io/Valiant360/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.