New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video progress bar #46

Merged
merged 1 commit into from Aug 26, 2016

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Contributor

GuillaumeGomez commented Aug 21, 2016

However, it misses the css changes which follows:

.valiant-progress-bar {
    width: 100%;
    height: 8px;
    overflow: hidden;
}
.valiant-progress-bar:hover {
    cursor: pointer;
}
.valiant-progress-bar > div {
    height: 100%;
    float:left;
    background-color: #444;
}
.valiant-progress-bar > div:first-child {
    background-color: red;
}

for the simple reason that I have absolutely no clue where to find this file in here.

Fixes #30.

@flimshaw

This comment has been minimized.

Show comment
Hide comment
@flimshaw

flimshaw Aug 25, 2016

Owner

Thanks for this! i'll take a look this evening

Owner

flimshaw commented Aug 25, 2016

Thanks for this! i'll take a look this evening

@flimshaw flimshaw merged commit 97fb528 into flimshaw:master Aug 26, 2016

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:progress-bar branch Aug 26, 2016

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 26, 2016

Contributor

What will happen to the css?

Contributor

GuillaumeGomez commented Aug 26, 2016

What will happen to the css?

@flimshaw

This comment has been minimized.

Show comment
Hide comment
@flimshaw

flimshaw Aug 26, 2016

Owner

I merged it into the main .less file that holds it, and made a few minor tweaks. Thanks again, it's live on https://flimshaw.github.io/Valiant360/

Owner

flimshaw commented Aug 26, 2016

I merged it into the main .less file that holds it, and made a few minor tweaks. Thanks again, it's live on https://flimshaw.github.io/Valiant360/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment