Port some modular composition methods to generics - #2190
Merged
Conversation
…ed from fq_poly_templates)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following methods (plus underscore version) and replaces the counterparts in
fmpz_mod_polyandfq_poly_templateswith wrappers:All have been ported from
fq_poly_templates, with a few minor optimizations.There are some interfaces I would like to change, and some of the methods need clearer specifications, in particular with respect to error handling. However, my goal for now is just to keep the
fq_polyconventions to facilitate porting the polynomial factorization code to generics.Note: this PR decreases the library size though here is a net + lines of code since some legacy functions and their tests can't be removed yet. Once the factorization code is ported to generics we will be able to remove more code.