Add missing transpose functions, delegate a bunch of them to gr - #2203
Conversation
|
Some quick benchmark what the performance impact would be for fmpz_mat to transpose a 100x100 matrix of small values. In-place: Not in-place: I think for other types we basically don't care about this extra overhead, but integer matrices are worth having the best possible performance. Now if I try to optimize I get So the in-place version is suddenly extremely fast, but not in-place is still about 30% slower. Maybe we can live with that. We could recover that if we add some strided |
Co-authored-by: Fredrik Johansson <fredrik.johansson@gmail.com>
|
I applied your patch to |
|
Cool! Positive review from me. I'll make an issue about strided vector functions also. |
Also make their docstrings a bit more uniform. @albinahlback this would be another candidate for #2094