Fix various UB:s reported by GCC's address sanitizer#2220
Merged
fredrik-johansson merged 4 commits intoflintlib:mainfrom Jan 30, 2025
Merged
Fix various UB:s reported by GCC's address sanitizer#2220fredrik-johansson merged 4 commits intoflintlib:mainfrom
fredrik-johansson merged 4 commits intoflintlib:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some signed integer overflows, shifts out of range for the type, etc.
All instances I fixed looked completely harmless (wraparound arithmetic did the right thing) but this will cut down on the noise if someone wants to use the address sanitizer to hunt down more serious bugs.
There are plenty of these left, notably in the
mpolymodules where a more careful look might be needed. Alsoarb_dotand its variants have some signed integer overflows that are harmless because they only occur when the result will not be used in the end. I'm not sure how to fix those cleanly.Also adds
FLINT_UABSfor safely converting anslongto its absolute value as aulong.