Inline code in _gr_fmpz_set#2229
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #2203 we noticed a small speed regression when converting
fmpz_mat_transposeto generics.It turns out that this has a simple explanation: the double function call overhead
_gr_fmpz_set->fmpz_set. When the operation is inlined in_gr_fmpz_set,fmpz_mat_transposenow runs exactly as fast as the previous non-generic code (and slightly faster than the originalfmpz_mat_transposedid with the old matrix representation in FLINT 3.1).We should do this inlining in more of the
gr_fmpzmethods, but currently this isn't urgent since we don't use a lot of generics in thefmpzmodules yet.