Path param in prefilter function is not useful #19

Closed
ravishivt opened this Issue Jun 6, 2014 · 3 comments

Projects

None yet

3 participants

@ravishivt

The prefilter function often passes an empty path. This param should include the entire path of where the key param exists in the JSON tree. The current empty or one level path is not enough info to make a decision on whether to filter the diff.

@flitbit
Owner
flitbit commented Jun 6, 2014

I agree with your comment -- that is the intention of the path param so it seems there is a bug. I'll pull it down and add some tests/investigate.

@seanwoodward

@ravishivt do you find this happening when you are comparing arrays containing objects or objects with properties that are arrays containing objects?

@flitbit
Owner
flitbit commented Aug 13, 2014

I've got an update that I'm testing right now; it was indeed the path related to arrays. The fix will be a breaking change to the structure of changes. Any change below an array did not report paths correctly to the prefilter (was always null). More info in the check-in readme when it is ready (final).

@flitbit flitbit added the bug label Aug 13, 2014
@flitbit flitbit added a commit that closed this issue Aug 13, 2014
@flitbit fix #17, fix #19, close #21 dea80f2
@flitbit flitbit closed this in dea80f2 Aug 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment