Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fetchParams #19

Merged
merged 8 commits into from Mar 7, 2017
Merged

Improve fetchParams #19

merged 8 commits into from Mar 7, 2017

Conversation

tiggerk
Copy link
Contributor

@tiggerk tiggerk commented Mar 3, 2017

@tiggerk tiggerk self-assigned this Mar 3, 2017
@tiggerk tiggerk requested a review from dankang March 3, 2017 03:27
@dankang
Copy link
Contributor

dankang commented Mar 3, 2017

고생 많으셨습니다!

int type parsing 결과, array type 결과, safeInterger 관련 테스트 케이스도 있었으면 좋겠습니다.
나중에 추가하면 좋을 것 같아요.

@tiggerk
Copy link
Contributor Author

tiggerk commented Mar 3, 2017

@dankang 아! 테스트케이스 추가한 걸 아직 커밋안했네용! 커밋하면 한번 더 확인 부탁드릴께요! 감사합니당 😄

@@ -1,7 +1,7 @@
"use strict";

var imsiList = require('../dat/mcc_mnc.json')
, _ = require('underscore');
, _ = require('lodash/core');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여긴 lodash/core인 이유가 있어요?

Copy link
Contributor Author

@tiggerk tiggerk Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쓸데없는(지금 코드에서..) 다른 기능들 다빼고 core 기능만 require 한거에용!

@tiggerk tiggerk merged commit c5c9951 into flitto:master Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants