New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fetchParams #19
Conversation
tiggerk
commented
Mar 3, 2017
•
edited
edited
- Add geo-info to extra options
- protect against HTTP Parameter Pollution attacks (wish: document handling a param with multiple values #14)
- Add int, float type options for parameters
- package update
- Change the key name from x-flt to x-fetcher
* Add geo-info to extra options * protect against HTTP Parameter Pollution attacks * Add int, float type options for parameters
|
고생 많으셨습니다! int type parsing 결과, array type 결과, safeInterger 관련 테스트 케이스도 있었으면 좋겠습니다. |
|
@dankang 아! 테스트케이스 추가한 걸 아직 커밋안했네용! 커밋하면 한번 더 확인 부탁드릴께요! 감사합니당 |
| @@ -1,7 +1,7 @@ | |||
| "use strict"; | |||
|
|
|||
| var imsiList = require('../dat/mcc_mnc.json') | |||
| , _ = require('underscore'); | |||
| , _ = require('lodash/core'); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여긴 lodash/core인 이유가 있어요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
쓸데없는(지금 코드에서..) 다른 기능들 다빼고 core 기능만 require 한거에용!