Make James.listen work with no arguments like in the examples #9

Merged
merged 1 commit into from Jul 18, 2011

Conversation

Projects
None yet
2 participants
Contributor

ferrous26 commented Jul 18, 2011

In the examples, you have:

require 'rubygems'
require 'james'

# Your dialog goes here.

# This is needed to start James.
#
James.listen

Except that James.listen expects an argument to be passed so it can then pass it to James::Controller.instance.

In turn, James::Controller.instance does supply the default value for its argument.

I'm not sure if you meant for only James.listen to have a default value or both. In either case, this patch makes the example code work.

@floere floere added a commit that referenced this pull request Jul 18, 2011

@floere floere Merge pull request #9 from ferrous26/master
Make James.listen work with no arguments like in the examples
c83a1c0

@floere floere merged commit c83a1c0 into floere:master Jul 18, 2011

Owner

floere commented Jul 18, 2011

Thank you! Both should have a default value.

Owner

floere commented Jul 18, 2011

Released in 0.7.1.

Owner

floere commented Jul 18, 2011

Also added you to the contributors list :) Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment