Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Make James.listen work with no arguments like in the examples #9

Merged
merged 1 commit into from

2 participants

@ferrous26

In the examples, you have:

require 'rubygems'
require 'james'

# Your dialog goes here.

# This is needed to start James.
#
James.listen

Except that James.listen expects an argument to be passed so it can then pass it to James::Controller.instance.

In turn, James::Controller.instance does supply the default value for its argument.

I'm not sure if you meant for only James.listen to have a default value or both. In either case, this patch makes the example code work.

@floere floere merged commit c83a1c0 into from
@floere
Owner

Thank you! Both should have a default value.

@floere
Owner

Released in 0.7.1.

@floere
Owner

Also added you to the contributors list :) Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/james.rb
View
2  lib/james.rb
@@ -39,7 +39,7 @@ def self.use *dialogs
# Start listening.
#
- def self.listen options
+ def self.listen options = {}
controller.listen options
end
Something went wrong with that request. Please try again.