Skip to content
This repository
Browse code

Modified "default" so it can be used alone.

I'm not sure the best way to work "default" into the DSL since it's
effectively stating that there is only a CC+NDC and no Local part.
The DSL expects both.
  • Loading branch information...
commit 47d740903424df9cd6b35e2db005535a7accf88b 1 parent d0d9a83
Ralph Churchill mrchucho authored
2  lib/phony/countries.rb
@@ -496,7 +496,7 @@
496 496
497 497 country '970', fixed(2) >> split(3,2,2) # Reserved
498 498 country '971', fixed(2) >> split(3,2,2) # United Arab Emirates
499   - country '972', fixed(2) >> split(3,2,2) # Israel (State of)
  499 + country '972', default # Israel (State of)
500 500 country '973', fixed(2) >> split(3,2,2) # Bahrain (Kingdom of)
501 501 country '974', fixed(2) >> split(3,2,2) # Qatar (State of)
502 502 country '975', fixed(2) >> split(3,2,2) # Bhutan (Kingdom of)
2  lib/phony/dsl.rb
@@ -74,7 +74,7 @@ def match regex, options = {}
74 74 NationalSplitters::Regex.instance_for regex, options[:on_fail_take]
75 75 end
76 76 def default
77   - NationalSplitters::Default.instance_for
  77 + none >> NationalSplitters::Default.instance_for
78 78 end
79 79
80 80 # Local splitters.
5 spec/lib/phony_spec.rb
@@ -193,6 +193,11 @@
193 193 Phony.format('414436435').should == '+41 44 364 35'
194 194 end
195 195 end
  196 + context '"unsupported" countries' do
  197 + it 'handles normalizing, then formatting' do
  198 + Phony.format(Phony.normalize('+880-321 5560 5220')).should == '+880 32155605220'
  199 + end
  200 + end
196 201 end
197 202
198 203 context "speed" do

0 comments on commit 47d7409

Please sign in to comment.
Something went wrong with that request. Please try again.