Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Move lib/countries.rb to phony/ #21

Closed
trans opened this Issue May 1, 2011 · 2 comments

Comments

Projects
None yet
2 participants

trans commented May 1, 2011

Just a project organization issue. Technically it's not good to put a file directly under lib that doesn't share the name of your project. So specifically in Phony's case, the countries.rb file should be moved to the phony/ directory. The reason being, if someone else wanted to create a project called countries then there would be a naming conflict.

Owner

floere commented May 1, 2011

Good point. And let's just say it is a bad idea™ :)

I'll move it into lib, perhaps renaming it, and update the blog post. Thanks again!

Will be released in 1.4.1 in 2 hours.

Owner

floere commented May 1, 2011

1.4.1 released, with countries.rb moved into phony/ Thanks, much appreciated!

@floere floere closed this May 1, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment