Colons #70

Closed
cczona opened this Issue Dec 24, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@cczona

cczona commented Dec 24, 2012

Is this example as intended?

 it "should normalize a number with colons" do
    Phony.normalize('1.906.387.1698').should == '19063871698'
  end

https://github.com/floere/phony/blob/master/spec/lib/phony_spec.rb#L48-L50

@floere

This comment has been minimized.

Show comment Hide comment
@floere

floere Dec 24, 2012

Owner

Yes, why do you ask? :)

Also see for reference on E164:
http://en.wikipedia.org/wiki/E.164

Owner

floere commented Dec 24, 2012

Yes, why do you ask? :)

Also see for reference on E164:
http://en.wikipedia.org/wiki/E.164

@cczona

This comment has been minimized.

Show comment Hide comment
@cczona

cczona Dec 24, 2012

Asked because in my country (US) the character called "colon" is ":" rather than "."

Is it customary to describe "." as a "colon" in other parts of the world?

cczona commented Dec 24, 2012

Asked because in my country (US) the character called "colon" is ":" rather than "."

Is it customary to describe "." as a "colon" in other parts of the world?

@floere

This comment has been minimized.

Show comment Hide comment
@floere

floere Dec 25, 2012

Owner

Ah, LOL. No it isn't – feel free to send a pull request if you want to :)

Owner

floere commented Dec 25, 2012

Ah, LOL. No it isn't – feel free to send a pull request if you want to :)

@floere floere closed this Jan 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment