Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Changes to avoid issues with normalizing a phone number started with reserved +0 country code. #180
We've faced an issue with normalizing a test phone number that starts with reserved +0 country code. The issue was with normalize() method that returned '0' as a normalized phone number when we used "+00 000 000 000" number in our test cases. It's not a big dial to use another test number but from my point of view such wrong numbers should have not be recognized as a valid # as +0 zone is not assigned to a country.
No problem. To avoid having commits being automatically added, use separate branches for each pull request.
I am not sure I understand the test case – why do you have a test case for a 0 number? I'm curious as to what the goal of it is. The E164 standard is quite silent on the topic of reserved country codes (iirc).
I'll pull this pull request and will probably add a handler for reserved numbers which returns
Many thanks for your work!