Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese freephone starts with 0800 has 7 digit in local part #424

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
4 participants
@fujimura
Copy link
Contributor

fujimura commented Dec 20, 2018

Japanese freephone starts with 0120 has 6 in local part, after it, but ones start with 0800 has 7 digit.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 20, 2018

Coverage Status

Coverage increased (+0.0002%) to 99.407% when pulling e6d9327 on fujimura:japanese-freephone-starts-with-0800-has-7-digit-in-local-part into 085fee5 on floere:master.

3 similar comments
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 20, 2018

Coverage Status

Coverage increased (+0.0002%) to 99.407% when pulling e6d9327 on fujimura:japanese-freephone-starts-with-0800-has-7-digit-in-local-part into 085fee5 on floere:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 20, 2018

Coverage Status

Coverage increased (+0.0002%) to 99.407% when pulling e6d9327 on fujimura:japanese-freephone-starts-with-0800-has-7-digit-in-local-part into 085fee5 on floere:master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 20, 2018

Coverage Status

Coverage increased (+0.0002%) to 99.407% when pulling e6d9327 on fujimura:japanese-freephone-starts-with-0800-has-7-digit-in-local-part into 085fee5 on floere:master.

@knu

This comment has been minimized.

Copy link

knu commented Dec 20, 2018

Here's the relevant official press release from the Japanese government back in 1999:
http://www.soumu.go.jp/main_sosiki/joho_tsusin/pressrelease/japanese/denki/990708j601.html

This is written in Japanese, but I hope you can find the 800DEFGHJK (800DEFGHJK) part, which indicates they assigned 7 digit phone numbers followed by 800.

@knu

This comment has been minimized.

Copy link

knu commented Jan 25, 2019

@floere Can you please merge this when you have a chance? Thank you!

@floere floere merged commit 6b44698 into floere:master Feb 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0002%) to 99.407%
Details
@floere

This comment has been minimized.

Copy link
Owner

floere commented Feb 3, 2019

@knu Sorry for the long wait! 🙇 Many thanks to you for this nice PR! 👍 Released in 2.16.10 🚀

@fujimura fujimura deleted the fujimura:japanese-freephone-starts-with-0800-has-7-digit-in-local-part branch Feb 4, 2019

@fujimura fujimura restored the fujimura:japanese-freephone-starts-with-0800-has-7-digit-in-local-part branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.