Picky deletes non-ascii chars from the id. #91

Closed
reactormonk opened this Issue Nov 29, 2012 · 3 comments

Comments

Projects
None yet
3 participants
Contributor

reactormonk commented Nov 29, 2012

Steps to reproduce:

  • Clone from

    git://github.com/Tass/magic_search.git

  • Build and install the gems from cards and mana-symbols

  • bundle install in the server dir

  • rake spec

Results:

 Failure/Error: it { cards.search_for('Arm with').should include('Arm with Æther') }
   expected ["Arm with ther"] to include "Arm with Æther"

quasor commented Dec 28, 2012

Ouch, just got bit by this deleting an @ symbol from an email address.

Owner

floere commented Dec 28, 2012

Sorry about that guys! I do not dup the String for the id before indexing so it gets changed in place when tokenizing. The reason was performance and the fact that not many people tokenized the String that gets used for the id. It seems that I have been wrong. This will change in Picky 5 at the latest.

Owner

floere commented Mar 2, 2013

Duplicate of #106

floere closed this Mar 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment