Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Small fixes for the generator library #96

Merged
merged 2 commits into from

2 participants

Kaspar Schiess Florian R. Hanke
Kaspar Schiess
Collaborator

Hi there,

I just ran your getting started tutorial and noticed that:
1. The client generator said to run 'rake index' - no need for that, right?
2. The rake gem was missing from the client Rakefile.

Here's a toke request for fixing both.
greetings,
kaspar

kschiess added some commits
Kaspar Schiess kschiess Removes 'rake index' from inline documentation
The generator for the client says to run 'rake index' - this makes no
sense on the client, since there is nothing to index.
1d230eb
Kaspar Schiess kschiess Add 'rake' gem into Gemfile
The client generator generates a Rakefile. This includes the 'rake' gem
into the development group, making sure that we control the version of
the 'rake' installed.
e882de8
Florian R. Hanke
Owner

Thanks! (You, btw, don't need to create pull requests if you don't want to :) )

Florian R. Hanke floere merged commit dea356d into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 6, 2012
  1. Kaspar Schiess

    Removes 'rake index' from inline documentation

    kschiess authored
    The generator for the client says to run 'rake index' - this makes no
    sense on the client, since there is nothing to index.
  2. Kaspar Schiess

    Add 'rake' gem into Gemfile

    kschiess authored
    The client generator generates a Rakefile. This includes the 'rake' gem
    into the development group, making sure that we control the version of
    the 'rake' installed.
This page is out of date. Refresh to see the latest.
1  generators/lib/picky-generators/generators/client/sinatra.rb
View
@@ -26,7 +26,6 @@ def generate
[
"cd #{name}",
"bundle install",
- "rake index",
"unicorn -p 3000 # (optional) Or use your favorite web server.",
"open http://localhost:3000/",
"rake todo # (optional) Shows you where Picky needs input from you."
3  generators/prototypes/client/sinatra/Gemfile
View
@@ -1,4 +1,4 @@
-source :gemcutter
+source :rubygems
# Gems required by the Picky client.
#
@@ -10,4 +10,5 @@ gem 'haml'
group :development do
gem 'sinatra-reloader'
+ gem 'rake'
end
Something went wrong with that request. Please try again.