Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPAddress boolean and factory methods #440

Merged
merged 4 commits into from
Oct 27, 2015
Merged

IPAddress boolean and factory methods #440

merged 4 commits into from
Oct 27, 2015

Conversation

ronaldchl
Copy link
Contributor

@bsn-abat
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins.bigswitch.com//job/loxigen_pull_req/196/
Test PASSed.

@ronaldchl
Copy link
Contributor Author

The isUnspecified() name came from:

@gregor-bsn
Copy link
Contributor

LGTM

@andi-bigswitch
Copy link
Contributor

ACK

@bsn-abat
Copy link

ABAT: START_MERGE: Log file at http://vss1/abat/2015.10.27.2113-m.loxigen.master/abat.log

bsn-abat pushed a commit to floodlight/loxigen-artifacts that referenced this pull request Oct 27, 2015
Artifacts from floodlight/loxigen@b3b3cfd...fb90801
a16b52c 
Loxigen Head commit floodlight/loxigen@fb90801
commit fb90801d4d2e9ba5ba10803d2d0dd03665cd9988
Merge: b3b3cfd 1a3a98f
Author: abat <abat@bigswitch.com>
Date:   Tue Oct 27 14:13:50 2015 -0700

    Merge into master from pull request #440:
    IPAddress boolean and factory methods (floodlight/loxigen#440)

commit 1a3a98fff73ce58097264d6652a2181877935174
Author: Ronald Li <ronald.li@bigswitch.com>
Date:   Fri Oct 23 18:01:18 2015 -0700

    Added factory method IPv4Address.of(int, int, int, int)

commit 536dda87a1be9df3dc5f20b92cb8f6abb3924b1f
Author: Ronald Li <ronald.li@bigswitch.com>
Date:   Thu Oct 22 17:16:29 2015 -0700

    Added IPAddress#isLinkLocal() to test for link local addresses

commit 88a5ea5e01d2f68994b83c86239f1c304d05823b
Author: Ronald Li <ronald.li@bigswitch.com>
Date:   Thu Oct 22 16:01:42 2015 -0700

    Added IPAddress#isLoopback() to test for loopback addresses

commit bbd1434a4ad9d69d1d2e75a52e66eaec61539069
Author: Ronald Li <ronald.li@bigswitch.com>
Date:   Thu Oct 22 14:53:55 2015 -0700

    Added IPAddress#isUnspecified() to test for wildcard addresses
@bsn-abat
Copy link

ABAT: ACCEPT: Successfully merged

In case you want to see the build log, check out :
Log file at http://vss1/abat/2015.10.27.2113-m.loxigen.master/abat.log
/cc

@bsn-abat bsn-abat merged commit 1a3a98f into floodlight:master Oct 27, 2015
bsn-abat pushed a commit that referenced this pull request Oct 27, 2015
Merge into master from pull request #440:
fb90801 
IPAddress boolean and factory methods (#440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ronaldchl @bsn-abat @gregor-bsn @andi-bigswitch