Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "REST API should support the username attribute" ITT-1785 #20

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Projects
None yet
2 participants
@floragunncom
Copy link
Owner

commented Dec 13, 2018

Maybe breaking but i think its right: don't accept usernames with dots

@floragunncom floragunncom requested review from jochenkressin and nibix Dec 13, 2018

@jochenkressin
Copy link
Collaborator

left a comment

Why don't we accept dots here? The "username" field was introduced to work around the "no dots in keys" issue when working with the YAML config files. Shouldn't the REST API behave the same?

@floragunncom

This comment has been minimized.

Copy link
Owner Author

commented Dec 14, 2018

@jochenkressin no dots in the url -> /_searchguard/api/user/my.user will be denied

@jochenkressin

This comment has been minimized.

Copy link
Collaborator

commented Dec 14, 2018

Right, my mistake, makes sense now

@floragunncom floragunncom merged commit ae1c461 into master Dec 14, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@floragunncom floragunncom deleted the ITT-1785 branch Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.