New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermediate/root selection logic bug #1

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@fbs
Contributor

fbs commented Mar 22, 2018

Because the getIntermediate and getRoot calls can return null this
leads to a NullPointerException.

Fix intermediate/root selection logic bug
Because the `getIntermediate` and `getRoot` calls can return `null` this
leads to a NullPointerException.

@floragunncom floragunncom requested a review from nibix Mar 22, 2018

@fbs

This comment has been minimized.

Show comment
Hide comment
@fbs

fbs Mar 22, 2018

Contributor

Issue without the patch:

./tools/sgtlstool.sh -c config/es02.yaml -t . -crt
WARNING: JAVA_HOME not set, will use /usr/bin/java
Exception in thread "main" java.lang.NullPointerException
	at com.floragunn.searchguard.tools.tlstool.tasks.LoadCa.<init>(LoadCa.java:51)
	at com.floragunn.searchguard.tools.tlstool.SearchGuardTlsTool.run(SearchGuardTlsTool.java:184)
	at com.floragunn.searchguard.tools.tlstool.SearchGuardTlsTool.main(SearchGuardTlsTool.java:65)

With the patched jar copied into deps/:

./tools/sgtlstool.sh -c config/es02.yaml -t . -crt
Error reading encrypted file ./root-ca.key; bad password?
No files have been written
Contributor

fbs commented Mar 22, 2018

Issue without the patch:

./tools/sgtlstool.sh -c config/es02.yaml -t . -crt
WARNING: JAVA_HOME not set, will use /usr/bin/java
Exception in thread "main" java.lang.NullPointerException
	at com.floragunn.searchguard.tools.tlstool.tasks.LoadCa.<init>(LoadCa.java:51)
	at com.floragunn.searchguard.tools.tlstool.SearchGuardTlsTool.run(SearchGuardTlsTool.java:184)
	at com.floragunn.searchguard.tools.tlstool.SearchGuardTlsTool.main(SearchGuardTlsTool.java:65)

With the patched jar copied into deps/:

./tools/sgtlstool.sh -c config/es02.yaml -t . -crt
Error reading encrypted file ./root-ca.key; bad password?
No files have been written

@nibix nibix merged commit 6f3c7fd into floragunncom:master Mar 23, 2018

@floragunncom

This comment has been minimized.

Show comment
Hide comment
@floragunncom

floragunncom Mar 27, 2018

Owner

@fbs thx for contributing

Owner

floragunncom commented Mar 27, 2018

@fbs thx for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment