New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the upcoming TZInfo v2.0.0 release #9

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
2 participants
@philr
Contributor

philr commented Oct 28, 2017

I'm the maintainer of the tzinfo gem. et-orbi currently depends on tzinfo with open-ended version constraints.

I'm working on a new major release of tzinfo (v2.0.0), which I hope to release sometime in the coming months. This will break backwards compatibility in a few ways that affect et-orbi:

  • The TimezonePeriod#to_local and TimezonePeriod#to_utc methods have been removed. Timezone#utc_to_local and Timezone#local_to_utc should be used instead.
  • TZInfo::TransitionDataTimezoneInfo has been replaced with TZInfo::DataSources::ConstantOffsetDataTimezoneInfo and TZInfo::DataSources::TransitionsDataTimezoneInfo.
  • Methods that return local times (such as Timezone#utc_to_local) now return results using the appropriate local UTC offset instead of always using UTC.

This pull request includes changes that make et-orbi compatible with both the upcoming tzinfo v2.0.0 release and existing tzinfo releases.

To test with the current development version of tzinfo instead of a released version, you can add the following line to the Gemfile:

gem 'tzinfo', git: 'https://github.com/tzinfo/tzinfo.git'

@jmettraux jmettraux self-assigned this Oct 28, 2017

@jmettraux jmettraux merged commit 730f2e5 into floraison:master Oct 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmettraux

This comment has been minimized.

Show comment
Hide comment
@jmettraux

jmettraux Oct 28, 2017

Member

Hello @philr, yes, I know who you are. I follow you. Thanks for all your work. It's everywhere Ruby is.

Thanks for this, it spares me many many headaches.

Have a nice day!

Member

jmettraux commented Oct 28, 2017

Hello @philr, yes, I know who you are. I follow you. Thanks for all your work. It's everywhere Ruby is.

Thanks for this, it spares me many many headaches.

Have a nice day!

@philr philr deleted the philr:support_tzinfo_v2 branch Oct 29, 2017

@jmettraux jmettraux referenced this pull request May 24, 2018

Closed

tzinfo 2.0.0 availability #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment