Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_toot_chars value is string rather than integer #161

Closed
mthld opened this issue Aug 9, 2019 · 4 comments

Comments

@mthld
Copy link

commented Aug 9, 2019

Hi,

I migrated my account to a Florence instance but now I can't use my iOS client.
It seems that you modified the max_toot_chars value type. What's the purpose of this move?
Would you publish some docs to help app dev implement that?

Here is the issue I opened on the iOS client Toot! repo: DagAgren/toot#340

Thanks in advance,

@1011X

This comment has been minimized.

Copy link
Member

commented Aug 11, 2019

Hey, thanks for submitting an issue.

The problem was that max_toot_chars was being passed as-is, and the way everything is stored in settings is as a string, so the necessary conversion to an integer wasn't being done. There will be a PR that fixes this soon.

@mthld

This comment has been minimized.

Copy link
Author

commented Aug 16, 2019

Hi,

I’ve seen @1011X work has been merged in main branch, but can you tell me when a new release will be published?

Thanks again,

@clarfon

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

@mthld we've been relatively swamped this week but I'll try and make sure a release gets done over the weekend.

@clarfon clarfon added this to the v0.0.1.2 (Pre-Release 0.1.2) milestone Aug 17, 2019

@mthld

This comment has been minimized.

Copy link
Author

commented Aug 17, 2019

@clarfon alright, many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.