New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CFLAGS options in ext/json/ext/{generator,parser}/extconf.rb #166

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@vzvu3k6k

vzvu3k6k commented Mar 22, 2013

ext/json/ext/{generator,parser}/extconf.rb have some problems.

  1. generator/extconf.rb enables -O0 -ggdb when $DEBUG is false.
  2. When $CFLAGS contains -Ofast, extconf.rb replaces it with -O3fast. It is invalid and causes compile error.

This patch fixes these two problems.

vzvu3k6k added some commits Mar 21, 2013

Simplify overwriting CFLAG
The original code replaces " -Ofast" with " -O3fast",
which is an invalid option and causes compile error.
Just adding " -O3" is more simple and robust than replacing.
@flori

This comment has been minimized.

Show comment
Hide comment
@flori

flori Jan 9, 2015

Owner

Fixed by deletion, actually.

Owner

flori commented Jan 9, 2015

Fixed by deletion, actually.

@vzvu3k6k

This comment has been minimized.

Show comment
Hide comment
@vzvu3k6k

vzvu3k6k Jan 9, 2015

OK, close the request.

vzvu3k6k commented Jan 9, 2015

OK, close the request.

@vzvu3k6k vzvu3k6k closed this Jan 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment