Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline changes to help (JRuby) development #371

Merged
merged 3 commits into from Jun 25, 2020
Merged

Conversation

kares
Copy link
Contributor

@kares kares commented Jan 12, 2019

these were originally part of #361

the most relevant change is that we weren't able to run tasks test_pure and test_ext as intended.
... one needed to do: env JSON=pure bundle exec rake test_pure

@kares kares changed the title baseline changes to help (further) JRuby development baseline changes to help (JRuby) development Jan 12, 2019
@kares
Copy link
Contributor Author

kares commented Feb 21, 2019

// cc @headius please review and ping @hsbt for merging

@kares
Copy link
Contributor Author

kares commented Mar 1, 2019

some progress on master from @flori: 0e97fd4 ... wondering if we can get the remaining 2 commits in?

@kares
Copy link
Contributor Author

kares commented Jun 25, 2020

... could we get this in that here, for future json work or do we have to do smt differently?

Copy link
Contributor

@olleolleolle olleolleolle left a comment

These changes make JRuby builds possible and more practical! LGTM!

@hsbt hsbt merged commit 23aabc2 into flori:master Jun 25, 2020
1 check passed
@headius
Copy link
Contributor

headius commented Jun 25, 2020

Sorry this flew under my radar. The changes look fine.

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants