Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning regarding HVACMode(s) #19

Open
romicaiarca opened this issue Feb 15, 2024 · 3 comments
Open

Warning regarding HVACMode(s) #19

romicaiarca opened this issue Feb 15, 2024 · 3 comments

Comments

@romicaiarca
Copy link

Warning regarding HVACMode(s)

Entity None (<class 'custom_components.salusfy.climate.SalusThermostat'>) implements HVACMode(s): heat, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/floringhimie/salusfy/issues

Screenshot 2024-02-15 at 10 27 01
@matthewturner
Copy link

I've been able to resolve this issue with:

class Entity(ClimateEntity):
    def __init__(self):
          self._enable_turn_on_off_backwards_compatibility = False

    @property
    def supported_features(self):
        return ClimateEntityFeature.TARGET_TEMPERATURE | ClimateEntityFeature.TURN_ON | ClimateEntityFeature.TURN_OFF

I've fixed it in my fork. There are quite a lot of changes so I can't easily submit a PR for just this change.

Hope it helps!

@romicaiarca
Copy link
Author

it works. I've added your fork into my instance and looks like works like a charm!

@matthewturner
Copy link

Great! Glad it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants