Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix suggestion engine selection crash #2492

Merged
merged 3 commits into from
Jun 22, 2024
Merged

fix suggestion engine selection crash #2492

merged 3 commits into from
Jun 22, 2024

Conversation

lm41
Copy link
Member

@lm41 lm41 commented Jun 14, 2024

Closes: #2482

@lm41 lm41 requested a review from patrickgold June 15, 2024 15:49
patrickgold
patrickgold approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@patrickgold patrickgold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for the changes, testing passed and changes look good, merging in

@patrickgold patrickgold merged commit 9d76b68 into master Jun 22, 2024
1 check passed
@patrickgold patrickgold deleted the lm41/fix/select-option-crash branch June 22, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickgold patrickgold patrickgold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App get crash when I click on - select - option
2 participants
@lm41 @patrickgold