Class names #1248

Open
EduardoOliveira opened this Issue Feb 13, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@EduardoOliveira

Hello,
First off all thank you for the great library.
I'm integrating Flot in an already running big website and i'm getting collisions with the class names, for instance the .legend is already defined in my website.
Personally I think that the Flot classes should have a prefix to avoid collisions.

Best Regards

@dnschnur dnschnur added this to the Release 1.0 milestone Feb 13, 2014

@dnschnur dnschnur added cleanup and removed cleanup labels Feb 13, 2014

@dnschnur

This comment has been minimized.

Show comment Hide comment
@dnschnur

dnschnur Feb 13, 2014

Member

Yes; we started doing that in 0.8 with the axis labels, e.g. using flot-tick-label instead of tickLabel. The goal by 1.0 is to have all classes prefixed; that will give us enough time to deprecate the old labels gradually, and not cause too much upgrade pain.

In the meantime I'd suggest placing your rules further down in the stylesheet, and using ancestry to differentiate them, e.g. #placeholder .legend { ... }.

Member

dnschnur commented Feb 13, 2014

Yes; we started doing that in 0.8 with the axis labels, e.g. using flot-tick-label instead of tickLabel. The goal by 1.0 is to have all classes prefixed; that will give us enough time to deprecate the old labels gradually, and not cause too much upgrade pain.

In the meantime I'd suggest placing your rules further down in the stylesheet, and using ancestry to differentiate them, e.g. #placeholder .legend { ... }.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment