Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Jquery version requirements #1250

Closed
EGLadona opened this Issue · 8 comments

3 participants

EGLadona David Schnur dmfalke
EGLadona

Please I am totally new to flot.

I have a site with jquery 1.11.1 and trying to play with zoom and selection. The zoom in the example does not work, but If I use the jquery (1.8.3) included in flot 0.8.2 distribution the zooming does work as expected. How to solve it ?

Thanks

David Schnur
Owner

What do you mean when you say it doesn't work? Do you see any errors in the console?

EGLadona
EGLadona

If can be of help, I have checked the example with:
jquery-1.11.0.min.js (Fail)
jquery-1.10.2.js (Fail)
jquery-1.10.1.min.js (Fail)
jquery-1.9.1.min.js (Fail)
jquery-1.8.3.js (ok !)
jquery-1.8.0.js (ok !)

The console on Chrome only shows a warning with the deprecated use of "event.returnValue" in previous versions of jquery except 1.11.

David Schnur
Owner

I've tested against 1.11.0 on Chrome, and I don't see any problems with the zooming example. Are you testing against the plain example, as it comes in the zip download, or are you combining it with other plugins or code?

David Schnur dnschnur added the triage label
EGLadona
dmfalke
EGLadona
David Schnur
Owner

I'm marking this as a bug, although the fix is not quite as straightforward as that; we still need to support versions of jQuery before prop was added. We'll need to add a little shim to cover both versions.

David Schnur dnschnur added this to the Release 0.8.3 milestone
David Schnur dnschnur added bug and removed triage labels
David Schnur dnschnur self-assigned this
David Schnur dnschnur referenced this issue from a commit in dnschnur/flot
David Schnur dnschnur Fix zoom to selection box when using jQuery 1.9+.
Fixes #1250.
4964dcb
David Schnur dnschnur closed this in #1285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.