Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Jquery version requirements #1250

Closed
EGLadona opened this Issue Feb 17, 2014 · 8 comments

Comments

Projects
None yet
3 participants

Please I am totally new to flot.

I have a site with jquery 1.11.1 and trying to play with zoom and selection. The zoom in the example does not work, but If I use the jquery (1.8.3) included in flot 0.8.2 distribution the zooming does work as expected. How to solve it ?

Thanks

Owner

dnschnur commented Feb 17, 2014

What do you mean when you say it doesn't work? Do you see any errors in the console?

Thanks David,

I mean that the shaded rectangle appears but after releasing the mouse,
the zooming is not done. There is no particular message in the console
associated to it, just the graphic does not zoom compared to the version
in http://www.flotcharts.org.

On 17/02/14 21:19, David Schnur wrote:

What do you mean when you say it doesn't work? Do you see any errors
in the console?


Reply to this email directly or view it on GitHub
#1250 (comment).

If can be of help, I have checked the example with:
jquery-1.11.0.min.js (Fail)
jquery-1.10.2.js (Fail)
jquery-1.10.1.min.js (Fail)
jquery-1.9.1.min.js (Fail)
jquery-1.8.3.js (ok !)
jquery-1.8.0.js (ok !)

The console on Chrome only shows a warning with the deprecated use of "event.returnValue" in previous versions of jquery except 1.11.

Owner

dnschnur commented Feb 24, 2014

I've tested against 1.11.0 on Chrome, and I don't see any problems with the zooming example. Are you testing against the plain example, as it comes in the zip download, or are you combining it with other plugins or code?

@dnschnur dnschnur added the triage label Feb 24, 2014

Thank you for your care on this problem. The answer is not. It is just
the same page as it comes with the flot zip file
(/examples/selection/index.html)
Please if you have time give a look at

Using Firefox I'm not able to see the zoom effect with the second one !.

For those pages I'm working on, I have circumvent the problem by loading
the version of Jquery that is ok ! but the problem is still there.

Thank

I've tested against 1.11.0 on Chrome, and I don't see any problems
with the zooming example. Are you testing against the plain example,
as it comes in the zip download, or are you combining it with other
plugins or code?


Reply to this email directly or view it on GitHub
#1250 (comment).

dmfalke commented Feb 28, 2014

The example code uses jQuery.fn.attr to test if the zoom checkbox is
checked (line 67). This should be changed to jQuery.fn.prop. See the
"Attributes vs. Properties" section:
http://api.jquery.com/prop/#entry-longdesc.

Cheers

On Fri, Feb 28, 2014 at 5:42 AM, EGLadona notifications@github.com wrote:

Thank you for your care on this problem. The answer is not. It is just
the same page as it comes with the flot zip file
(/examples/selection/index.html)
Please if you have time give a look at

Using Firefox I'm not able to see the zoom effect with the second one !.

For those pages I'm working on, I have circumvent the problem by loading
the version of Jquery that is ok ! but the problem is still there.

Thank

I've tested against 1.11.0 on Chrome, and I don't see any problems
with the zooming example. Are you testing against the plain example,
as it comes in the zip download, or are you combining it with other
plugins or code?

Reply to this email directly or view it on GitHub
#1250 (comment).

Reply to this email directly or view it on GitHubhttps://github.com/flot/flot/issues/1250#issuecomment-36339112
.

Dave

Understood , thank you !

The example code uses jQuery.fn.attr to test if the zoom checkbox is
checked (line 67). This should be changed to jQuery.fn.prop. See the
"Attributes vs. Properties" section:
http://api.jquery.com/prop/#entry-longdesc.

Cheers

On Fri, Feb 28, 2014 at 5:42 AM, EGLadona notifications@github.com
wrote:

Thank you for your care on this problem. The answer is not. It is just
the same page as it comes with the flot zip file
(/examples/selection/index.html)
Please if you have time give a look at

http://www.physocean.icm.csic.es/js/flot/examples/selection/index-11.html

Using Firefox I'm not able to see the zoom effect with the second one !.

For those pages I'm working on, I have circumvent the problem by loading
the version of Jquery that is ok ! but the problem is still there.

Thank

I've tested against 1.11.0 on Chrome, and I don't see any problems
with the zooming example. Are you testing against the plain example,
as it comes in the zip download, or are you combining it with other
plugins or code?

Reply to this email directly or view it on GitHub
#1250 (comment).

Reply to this email directly or view it on
GitHubhttps://github.com/flot/flot/issues/1250#issuecomment-36339112
.

Dave


Reply to this email directly or view it on GitHub
#1250 (comment).

Owner

dnschnur commented Mar 9, 2014

I'm marking this as a bug, although the fix is not quite as straightforward as that; we still need to support versions of jQuery before prop was added. We'll need to add a little shim to cover both versions.

@dnschnur dnschnur added this to the Release 0.8.3 milestone Mar 9, 2014

@dnschnur dnschnur added bug and removed triage labels Mar 9, 2014

@dnschnur dnschnur self-assigned this Apr 14, 2014

@dnschnur dnschnur added a commit to dnschnur/flot that referenced this issue Apr 15, 2014

@dnschnur dnschnur Fix zoom to selection box when using jQuery 1.9+.
Fixes #1250.
4964dcb

@dnschnur dnschnur closed this in #1285 Apr 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment