Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Flot uses tables for layout without ensuring reset/overriding of default styles. #174

Open
dnschnur opened this Issue Sep 28, 2012 · 3 comments

Comments

Projects
None yet
1 participant
Owner

dnschnur commented Sep 28, 2012

Original author: kyberneticist@gmail.com (January 06, 2009 20:05:58)

What steps will reproduce the problem?

  1. Specify a default table style for the site (say, margins, padding,
    border collapse, borders etc - typical stuff)
  2. Try creating a float graph with a label.

What is the expected output? What do you see instead?
Screwed up graph due to poor label styling.

Please provide any additional information below.

The workaround is to add extra styling for Flot's labels - what Flot should
be doing instead is resetting its styles and specifying them explicitly to
avoid default style issues. Flot probably shouldn't be using a table there
either, but that's another matter.

Original issue: http://code.google.com/p/flot/issues/detail?id=95

Owner

dnschnur commented Sep 28, 2012

From olau%iol...@gtempaccount.com on January 09, 2009 16:39:54
Actually, this is somewhat on purpose. If I hardcode the styles into the table, you
won't be able to override them with CSS. If you can find a way to keep this property,
without borking up on your use case, I'm all ears.

Owner

dnschnur commented Sep 28, 2012

From olau%iol...@gtempaccount.com on January 13, 2009 12:58:22
If anyone feels like coming up with a patch, I think the easiest way around this is
to replace the table with styling with divs as kyberneticist suggests. The code is in
insertLegend, it could be a fun little job. :)

Owner

dnschnur commented Sep 28, 2012

From olau%iol...@gtempaccount.com on February 20, 2009 15:22:36
I'm going to classify it as an enhancement for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment