drawBar method does not use offset value when filling the bar #382

Closed
dnschnur opened this Issue Sep 28, 2012 · 1 comment

1 participant

@dnschnur
Flot member

Original author: davidm...@gmail.com (February 10, 2010 14:05:32)

drawBar method does not use offset value when filling the bar

in the code underneath the comment '// fill the bar' offset is not used
when drawing the bar fill, but is used when drawing the outline.

Original issue: http://code.google.com/p/flot/issues/detail?id=303

@dnschnur
Flot member

From dnsch...@gmail.com on June 05, 2012 14:12:33
As far as I can tell the offset is zero in all cases; it's not clear what it is intended for. In addition to fixing this bug, we need to review the use of the parameter in general.

@dnschnur dnschnur was assigned Jul 22, 2013
@dnschnur dnschnur added a commit that closed this issue Aug 9, 2013
@dnschnur dnschnur Remove the unused offset parameter.
The drawBar method was always called with an offset of zero, and I see
no other way in which it is currently used. Resolves #382.
e2b9cf8
@dnschnur dnschnur closed this in e2b9cf8 Aug 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment