Invalid filling in IE8 and IE7 for very long lines #400

Closed
dnschnur opened this Issue Sep 28, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@dnschnur
Member

dnschnur commented Sep 28, 2012

Original author: helge...@gmail.com (March 11, 2010 14:15:18)

Check out the following link for a demostration of this bug:
http://i.imgur.com/HHuDN.png

As you can see, the filling algorithm doesn't fill to value=0, but are
instead following some random line, including the seemingly random point at
around Apr 24.

Here's another example, showing two of these seemingly random points:
http://i.imgur.com/wFTTN.png

It never happens on small sets of data, but if I give it enough rows of
data, this bug usually do appear.

Not really sure how I would go about fixing this myself; I was looking at
the code in plotLineArea(), but couldn't really see anything obvious. AFAIK
this might be a problem with excanvas and not Flot.

Original issue: http://code.google.com/p/flot/issues/detail?id=321

@dnschnur

This comment has been minimized.

Show comment Hide comment
@dnschnur

dnschnur Sep 28, 2012

Member

From olau%iol...@gtempaccount.com on March 15, 2010 10:38:00
Yeah, it's a bug in IEs VML implementation. It can't draw lines that have too many
points. It's a really weird issue. I reported a bug in excanvas, and partly fixed it
with a simple patch by splitting the line into pieces. However, this means that
filling won't work (that's the issue you're seeing). I gave up at that point. If
you're interested, the patch is here (it's still not applied, but I'm bundling the
patched excanvas with Flot):

http://code.google.com/p/explorercanvas/issues/detail?id=50

I'll leave the bug open for now, but I think it's really something that should be
fixed in excanvas. If you can amend my patch to fixup filling, it would be cool.

Member

dnschnur commented Sep 28, 2012

From olau%iol...@gtempaccount.com on March 15, 2010 10:38:00
Yeah, it's a bug in IEs VML implementation. It can't draw lines that have too many
points. It's a really weird issue. I reported a bug in excanvas, and partly fixed it
with a simple patch by splitting the line into pieces. However, this means that
filling won't work (that's the issue you're seeing). I gave up at that point. If
you're interested, the patch is here (it's still not applied, but I'm bundling the
patched excanvas with Flot):

http://code.google.com/p/explorercanvas/issues/detail?id=50

I'll leave the bug open for now, but I think it's really something that should be
fixed in excanvas. If you can amend my patch to fixup filling, it would be cool.

@dnschnur

This comment has been minimized.

Show comment Hide comment
@dnschnur

dnschnur Sep 28, 2012

Member

From dnsch...@gmail.com on May 08, 2012 20:25:59
Review this behavior and verify that it's an Excanvas bug, and there's nothing we can do in Flot to resolve it.

Member

dnschnur commented Sep 28, 2012

From dnsch...@gmail.com on May 08, 2012 20:25:59
Review this behavior and verify that it's an Excanvas bug, and there's nothing we can do in Flot to resolve it.

@dnschnur dnschnur closed this Feb 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment