Test canvas text on Konqueror #625

Closed
dnschnur opened this Issue Sep 28, 2012 · 8 comments

Comments

Projects
None yet
1 participant
Owner

dnschnur commented Sep 28, 2012

Original author: l...@dashjr.org (June 05, 2011 12:42:36)

Used in measureTickLabels, without checking for availability.

Original issue: http://code.google.com/p/flot/issues/detail?id=546

Owner

dnschnur commented Sep 28, 2012

From mcewen....@gmail.com on June 10, 2011 20:11:42
This issue also exists on any Opera version older than 10.60 (i.e. anything using Presto older than 2.6). http://www.opera.com/docs/specs/presto26/canvas/ shows the first version of presto where measureText is supported; older versions either don't show it or note it as unsupported (see http://www.opera.com/docs/specs/opera95/canvas/ for Presto 2.1).

The error which opera throws is: Type mismatch (usually non-object value supplied where object required)

See also http://tickets.musicbrainz.org/browse/MBS-2689 which is the downstream issue . That one shows line 33, since that's what it ends up in our minified version; however, the actual issue is line 873 in measureTickLabels:

m = ctx.measureText(line.text);

The example pages at http://people.iola.dk/olau/flot/examples/ all work because of an older version of flot; that fallback method should probably be used when ctx.measureText is undefined.

Owner

dnschnur commented Sep 28, 2012

From olau%iol...@gtempaccount.com on June 23, 2011 19:15:56
If you check the new NEWS.txt, there's some info. It was also discussed on the mailing list.

I'm not sure we're going to stay with canvas text for default, though, it has some upsides, but fewer than I hoped, and some definite downsides.

Owner

dnschnur commented Sep 28, 2012

From l...@dashjr.org on June 23, 2011 19:25:42
I found nothing relevant in NEWS.txt.

Owner

dnschnur commented Sep 28, 2012

From olau%iol...@gtempaccount.com on June 23, 2011 19:33:02
Strange, it's one of the first things mentioned:

"Axis labels are now drawn with canvas text with some parsing to
support newlines. This solves various issues but also means that they
no longer support HTML markup, can be accessed as DOM elements or
styled directly with CSS. Some older browsers lack this function of
the canvas API (this doesn't affect IE); if this is a problem, either
continue using an older version of Flot or try an emulation helper
such as canvas-text or Flashcanvas."

If you search on the mailing list for canvas text, my announcement and resulting discussions should turn up. But as a said, we might still move the canvas text dependency to a plugin.

Owner

dnschnur commented Sep 28, 2012

From mcewen....@gmail.com on June 23, 2011 19:33:24
First paragraph:

Axis labels are now drawn with canvas text with some parsing to
support newlines. This solves various issues but also means that they
no longer support HTML markup, can be accessed as DOM elements or
styled directly with CSS. Some older browsers lack this function of
the canvas API (this doesn't affect IE); if this is a problem, either
continue using an older version of Flot or try an emulation helper
such as canvas-text or Flashcanvas.

http://code.google.com/p/canvas-text/ is the canvas-text that's referred to, I think.

Owner

dnschnur commented Sep 28, 2012

From mcewen....@gmail.com on June 23, 2011 19:33:57
Heh, beat me to it.

Owner

dnschnur commented Sep 28, 2012

From dnsch...@gmail.com on May 08, 2012 20:30:36
Keeping this open as a reminder to test the new canvas text across a range of browsers if/when it's officially decided to include it in a release.

@ghost ghost assigned dnschnur Nov 3, 2012

Owner

dnschnur commented Mar 26, 2013

We've reverted to using HTML text as the default, with canvas available via a plugin. Konqueror still fails when that plugin is enabled, but the standard behavior (tested on Konqueror 4.4 - 4.9) once again works. We can't do much beyond this without more effort and complexity than it's worth.

@dnschnur dnschnur closed this Mar 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment