Improve the performance of large data processing #1221

Merged
merged 2 commits into from Apr 13, 2014

Conversation

Projects
None yet
3 participants
Contributor

soenter commented Jan 11, 2014

Example is the best teacher

Member

nschonni commented Jan 11, 2014

$.each has poor performance, why would that be an improvement

Contributor

soenter commented Jan 11, 2014

plot.getXAxes() not too much,plot.setupGrid() and plot.draw() improve the performance of key

------------------ 原始邮件 ------------------
发件人: "Nick Schonning";notifications@github.com;
发送时间: 2014年1月11日(星期六) 上午9:24
收件人: "flot/flot"flot@noreply.github.com;
抄送: "Soenter"sun_mingtao@qq.com;
主题: Re: [flot] Improve the performance of large data processing (#1221)

$.each has poor performance, why would that be an improvement


Reply to this email directly or view it on GitHub.

Owner

dnschnur commented Jan 25, 2014

A regular loop would be faster, but for how small the arrays are it's negligible. I would probably have used a loop, but this is arguably clearer. The main thing is that it gets rid of the plot; I've been meaning to update the examples this way for a while. I see too many questions on the forums and on Stack Overflow that re-plot unnecessarily, and then wonder about state being lost or poor performance.

Could you please fix the indentation (spaces -> tabs) to match the rest of the file? I know that the rest doesn't actually match the style guide, but I'd like to keep master consistent while we're still working on 0.9.

dnschnur added a commit that referenced this pull request Apr 13, 2014

Merge pull request #1221 from soenter/master
Improve the performance of large data processing

@dnschnur dnschnur merged commit 3aec7ce into flot:master Apr 13, 2014

1 check failed

default The Travis CI build failed
Details

@dnschnur dnschnur self-assigned this Apr 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment