Skip to content

Exposing the hardcoded defaultValue property as a configuration option for Lines #1234

Closed
wants to merge 107 commits into from
@dougloyo

I had the need to create a chart that would point out deviation from a set goal.
I.E. Historical Student attendance goal of 80%.

As you can see in figure 1 when activating the fill:true parameter the fill will take a baseline of 0 (which is a hardcoded value).
Figure 1.
image

In figure 2 I have the chart working as I need it and probably others do. (exposing the property as a configuration value in the Lines properties.
Figure 2.
after

Change is very simple please look at the diff.

k-nut and others added some commits Mar 22, 2013
@k-nut k-nut No more jshint errors for jquery.colorhelpers.js 814528c
@djamshed djamshed Allow custom stroke color for points. 3ae7177
@k-nut k-nut reverted null check 672b9b8
@dnschnur dnschnur Update version number to 0.9.0-alpha. 8722a99
@dnschnur dnschnur Added a .jshintrc for the Travis JSHint step. 25e93fe
@dnschnur dnschnur Update JSHint pattern to include colorhelpers. 8e12ecd
@dnschnur dnschnur Merge branch 'master' of https://github.com/k-nut/flot into code-cleanup e58c20f
@dnschnur dnschnur Added missing radix parameters. d3b2f0c
@dnschnur dnschnur Removed trailing whitespace. 4be713f
@dnschnur dnschnur Added missing semicolons. b3fe4bd
@dnschnur dnschnur Removed unnecessary semicolons. 0a28437
@dnschnur dnschnur Merge pull request #1003 from djamshed/pointsStrokeColor b425884
@dnschnur dnschnur Replace ternary with a simpler or statement. 89ad298
@dnschnur dnschnur Updated docs with the point strokeColor option. 0d26732
@dnschnur dnschnur Updated credits for #1003 strokeColor option. 1720941
@dnschnur dnschnur Merge tag '0.8.1' into 0.9-work 355331f
@dnschnur dnschnur Merge branch 'master' into code-cleanup 6833779
@dnschnur dnschnur Remove trailing white-space. e1684b4
@dnschnur dnschnur Convert single-quoted strings to double-quotes. 05dfea7
Karl Quinsland updated threshold plugin to work with 'above' operator db3a081
@dnschnur dnschnur Wrap one-statement if and for blocks in braces. f24a67e
@dnschnur dnschnur Fix mixed spaces and tabs. b8905be
@dnschnur dnschnur Fix lines incorrectly broken before an operator. 49c312c
@dnschnur dnschnur Switch to === and !== for safer equality testing. 9fc03e5
@dnschnur dnschnur Remove unused variable definitions. f39c71f
@dnschnur dnschnur Factor out duplicate variable definitions. e0413b9
@dnschnur dnschnur Wrap for...in loop bodies with hasOwnProperty. 5c005f6
@dnschnur dnschnur Add timezoneJS to the JSHint allowed globals.
We trust that jquery.flot.time.js checks for timezoneJS's existence
before using it.
2b744b1
@dnschnur dnschnur Merge pull request #1058 from kquinsland/threshholdUpdate
Updated threshold plugin to work with 'above' operator. Resolves #1059.
82da190
@dnschnur dnschnur Updated credits for threshold above operator. 13cbd2c
@dnschnur dnschnur Don't cache hasOwnProperty.
It's a little confusing, JSHint complains, and it doesn't make a big
difference anyway.
3de9c0e
@dnschnur dnschnur Miscellaneous code cleanup. ffcd71f
@dnschnur dnschnur Pull inline dependencies out into their own files.
We can inline the dependencies automatically as part of the build
process.
7970998
@dnschnur dnschnur Tweak Travis test target to omit dependencies. 1b29c62
@dnschnur dnschnur Fix further trailing and inconsistent whitespace. bd191ef
@dnschnur dnschnur Merge branch 'master' into 0.9-work bb18e09
@dnschnur dnschnur Merge branch 'code-cleanup' into 0.9-work
Conflicts:
	jquery.flot.js
	jquery.flot.threshold.js
b079efc
@dnschnur dnschnur Rename labelWidth/Height to tickWidth/Height. cfe16e1
@dnschnur dnschnur Minor reordering of axis options. 65c38d0
@dnschnur dnschnur Added axis.tickFont as an override for axis.font. 8d38774
@dnschnur dnschnur Updated axis option defaults and documentation.
Updated the axis option defaults and docs for tickColor, tickFont,
tickWidth, and tickHeight. Also re-organized the API docs to match the
master list, and revised many areas for clarity.
f75a5a5
@dnschnur dnschnur Inline legacyStyles; it wasn't reused anyway. 5209b8c
@dnschnur dnschnur Axes can now have basic horizontal text labels.
Labels are provided via a 'label' option on the axis, and can be styled
with the flot-axis-label class.  The labelFont option works similarly to
tickFont, as an override for the default font or the flot-axis-label
class.  The labelPadding option adds extra space between the axis and
its label.

Since most plots with axis labels currently use @markrcote's
flot-axislabels plugin, we also support the axisLabel and
axisLabelPadding options, and the axisLabels / axis[name]Label CSS
classes, to make it as easy as possible to transition from that plugin.
These are deprecated, and will be removed in 1.0.

The implementation uses the internal text API introduced in 0.8.
97f2a12
@dnschnur dnschnur Added core support for rotated HTML text. 6350cc6
@dnschnur dnschnur Rotate y-axis labels by 90 degrees.
The labels are rotated counter-clockwise for left axes and clockwise for
right axes.
4d1042a
@dnschnur dnschnur Merge pull request #1090 from dnschnur/axis-labels
Added axis labels and rotated text support.
4318eea
@trask trask Handle undefined axisOptions
I ran into this issue when upgrading from 0.8.1 to 0.9-work.
5e3ba78
@trask trask Highlight vertexes when no points
When series.points.show is false, currently a ring appears on highlight
around where the point would have been.  Instead, display the point on
highlight.
a17be4c
@nschonni nschonni Replace Makefile with Grunt 529a087
@nschonni nschonni Add EditorConfig setting
Allows for consistent spacing and indenting when combined with supported
IDEs
9fb67cf
@dnschnur dnschnur Merge pull request #1140 from nschonni/0.9-add-editorconfig
0.9 add editorconfig
aa2d7d1
@dnschnur dnschnur Merge pull request #1139 from nschonni/0.9-grunt-build
0.9 grunt build
d76e1cb
@nschonni nschonni Enforce indenting with JSHint
- Doesn't differentiate between tabs and spaces
- Switch/Case indenting may seem odd to some
678ff27
@dnschnur dnschnur Merge pull request #1141 from nschonni/0.9-jshint-indent4
0.9 jshint indent4
8e2f09a
@nschonni nschonni Convert remaining tabs to spaces 7c52f44
@sgissinger sgissinger Update jquery.flot.threshold.js
Displays the serie base color and the threshold color side by side in the legend.
When no treshold is color is set, default black color is used.
0006469
@dnschnur dnschnur Merge pull request #1145 from nschonni/0.9-tabs-to-spaces
Convert all tabs to 4-space indents.
5ae2236
@dnschnur dnschnur Merge pull request #1107 from trask/undefined-axis-options-fix
Handle undefined axisOptions in 0.9-work
80851c0
@dnschnur dnschnur Minor cleanup in axisOptions check. cc1d6bf
@dnschnur dnschnur Merge pull request #1152 from sgissinger/patch-3
Update jquery.flot.threshold.js
881fc00
@nschonni nschonni Rename Bower file
The component.json filename has been depreciated
0147811
@nschonni nschonni Add missing Bower package values
Values from package.json
f849daa
@nschonni nschonni Move non-Bower third party code under lib 4e66f98
@dnschnur dnschnur Merge pull request #1144 from nschonni/0.9-move-dependencies-to-bower
0.9 move dependencies to bower
7aeaf99
@ameyms ameyms Use jquery.isNumeric instead of typeof number 77405d8
@ameyms ameyms Use jsDoc style comments 61fb96d
@dnschnur dnschnur Merge pull request #1168 from ameyms/0.9-use-jq-isNumeric
A new isNumeric function instead of typeof number
6e76fff
@dnschnur dnschnur Merge branch '0.9-jsDoc-fix' of https://github.com/ameyms/flot into a…
…meyms-0.9-jsDoc-fix

Conflicts:
	jquery.flot.js
9bb52ea
@crayxt
crayxt commented on 4318eea Nov 1, 2013

Can the axis labels be rotated on xaxis? An update to examples will be appreciated.

Flot member

@crayxt Not yet, but that's what we're currently working on. There will definitely be examples for all of this.

dnschnur and others added some commits Nov 3, 2013
@dnschnur dnschnur Merge pull request #1113 from trask/highlight-vertexes-when-no-points
Highlight vertexes when no points
9671e73
@anthonyryan1 anthonyryan1 CSP compatibility for flot legend c14eaf4
@anthonyryan1 anthonyryan1 Fix an unrelated style guide violation merged earlier today 864ef02
@anthonyryan1 anthonyryan1 Address formatting concerns
* Removed self-closing tags
* Move the the nested divs into variables
* Expand the object literals for easier reading
b009b37
@anthonyryan1 anthonyryan1 Fix a serious oversight that occurred when merging pull request #919
…into 0.9-work for this pull request
bec29dc
@Ninir Ninir Added markdown files, txt files and the examples dir to the bower ign…
…ore rule
93ffe6b
@dnschnur dnschnur Merge pull request #1186 from Ninir/ignore_improvements
Bower.json - Ignore rule edition
9267b3e
@anthonyryan1 anthonyryan1 Fix the jQuery tag creation process
Move the rowBuffer definition closer to it's usage within the method
947ba2f
@dnschnur dnschnur Merge pull request #1184 from anthonyryan1/0.9-work
CSP compatibility (flot core)
8a7204d
@mcamenzind mcamenzind Added ability to resize the plot to a given size. 07a6189
@jBouyoud jBouyoud Patch for Issue 707 and 778
- Fixes the issue where steps altering user datapoints
- Do not altering user data points for drawing lines with steps 
(even stacked); just consider drawing with steps enables a different 
kind of plotting and clipping on lines and areas; that assuming that 
drawing with steps must always go horizontally and then verticaly 
(like previous inserted datapoints).
2e513c9
@jBouyoud jBouyoud Put a tab instead of with spaces 0706d03
@dnschnur dnschnur Merge pull request #1188 from mcamenzind/0.9-work
Added ability to resize the plot to a given size.
6578355
@dnschnur dnschnur Merge pull request #1194 from jBouyoud/0.9-patch-707-778
 Patch for Issue #707 and #778 (0.9-work)
c34744f
Jeff Tian Add missing references and minor update on jquery.flot.js.
Revert the change on jquery.flot.js

Revert the change on jquery.flot.js

Add missing references and minor update on jquery.flot.js.

Revert the change on jquery.flot.js

Revert changes on jquery.flot.js.

Revert the changes to the jquery.flot.js that made by Visual Studio 2012.
eae079f
@dnschnur dnschnur Merge pull request #1190 from Jeff-Tian/FixIssues
Add missing references and minor update on jquery.flot.js.
7593583
@nschonni nschonni Add .gitattributes file for EOL normalization 98aba43
@dnschnur dnschnur Merge pull request #1195 from nschonni/add-gitattributes
Add .gitattributes file for EOL normalization
a8aac7a
Jeff Tian Enrich the flot with the ability to add text into markings.
Use $.isArray instead of instanceof Array; Use full name for parameters.
b100f44
@dnschnur dnschnur Merge pull request #1178 from Jeff-Tian/0.9-work
Enrich Flot with the ability to add text into markings.
ea4bfb1
@dnschnur dnschnur Merge branch 'master' into 0.9-work
Conflicts:
	component.json
	flot.jquery.json
	jquery.flot.js
	jquery.flot.pie.js
	jquery.flot.resize.js
	lib/jquery.colorhelpers.js
	package.json
3035aaa
@dnschnur dnschnur Fixed style violations introduced by 0.8.2 merge. fc1e409
@naknak naknak Fix for issue 505: add touch events to jquery.flot.selection. Code ta…
…ken from google code issue 426,

updated to work against 0.9-work branch.
518396a
@naknak naknak Fix jslint issues with previous version b6d392b
Jeff Tian Allow 0 sized markings. 59767e6
@dnschnur dnschnur Merge pull request #1209 from Jeff-Tian/0.9-work
Allow text markings without a solid background.
c221fd3
@dnschnur dnschnur Merge pull request #1206 from naknak/issue505
Fix for issue 505: add touch events to jquery.flot.selection.
2d2efc5
@nschonni nschonni Add jQuery JSCS style checking
Grunt is bumped due to a bad peerDependency in the grunt plugin
67dce05
@nschonni nschonni JSCS: Remove space between function and bracket fcc7c16
@nschonni nschonni JSCS: Don't stick operators to values
Fix jQuery preset as per jscs-dev/node-jscs#117
339aab9
@nschonni nschonni JSCS: Adding missing spaces around operators 53c49b6
@nschonni nschonni JSCS: Fix JSDoc parameters e40c0c5
@nschonni nschonni JSCS: Remove Illegal spaces 20d8194
@nschonni nschonni JSCS: Remove multiple line breaks e1cd976
@nschonni nschonni JSCS: Combine variable declarations
This only covers declarations that are consecutive
f335b49
@dnschnur dnschnur Merge pull request #1229 from nschonni/add-grunt-jscs-checker
Add grunt jscs checker
1513877
@nschonni nschonni Fix JSCS task
- Remove reporter output, it was useful for triaging issues but no
longer required
- Add JSCS call to the default build chain
b52f09a
@dnschnur dnschnur Merge pull request #1231 from nschonni/fix-jscs-task
Fix JSCS task
a3a1404
@dougloyo dougloyo Enhancement to Lines options to expose the hardocoded defaultValue us…
…ed in fill.
e6ca992
@dougloyo

Bad branch I should have merged with .9 not master.,

@dougloyo dougloyo closed this Jan 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.