fix browser detection for jQuery > 2.0 #1246

Merged
merged 3 commits into from Feb 12, 2014

3 participants

@bastjan

jQuery removed $.support.leadingWhitespace from jquery greater 2.0
because support was dropped for IE 7/8. So if property is undefined,
we are pretty shure its ie > 8 or jQuery does not support the browser
anyway.

bastjan added some commits Feb 11, 2014
@bastjan bastjan fix browser detection for jQuery > 2.0
jQuery removed $.support.leadingWhitespace from jquery greater 2.0
because support was dropped for IE 7/8. So if property is undefined,
we are pretty shure its ie > 8 or jQuery does not support the browser
anyway.
143c61a
@bastjan bastjan no confusing use of "!" 6fd170d
@nschonni nschonni added the triage label Feb 11, 2014
@dnschnur
Flot member

Thanks for the patch! Could you just add a comment above that line to explain the assumption, please? I want to avoid someone coming along later and breaking the logic because they don't understand why it's there.

@dnschnur dnschnur added bug and removed triage labels Feb 12, 2014
@dnschnur dnschnur added this to the Release 0.9 milestone Feb 12, 2014
@dnschnur dnschnur self-assigned this Feb 12, 2014
@bastjan

Sure...

@dnschnur dnschnur merged commit 0b03106 into flot:0.9-work Feb 12, 2014

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment