"local" variables are being hoisted to global variables. #851

Merged
merged 2 commits into from Nov 1, 2012

Conversation

Projects
None yet
2 participants
Contributor

ncb000gt commented Nov 1, 2012

Locally declared insertSteps and fmt variables without var are being hoisted to the global scope and set there. This is causing issues with my testing, but should also be fixed in general.

ncb000gt added some commits Nov 1, 2012

insertSteps was being hoisted to global.
Locally declared insertSteps by adding var s.t. it would no longer be a
global variable.

Signed-off-by: Nick Campbell <nicholas.j.campbell@gmail.com>
fmt hoisted to global.
`fmt` was being hoisted as a global variable.

Signed-off-by: Nick Campbell <nicholas.j.campbell@gmail.com>
Owner

dnschnur commented Nov 1, 2012

Thanks for submitting this!

dnschnur added a commit that referenced this pull request Nov 1, 2012

Merge pull request #851 from ncb000gt/master
Prevent insertSteps and fmt from becoming global.

@dnschnur dnschnur merged commit 30946cb into flot:master Nov 1, 2012

@ghost ghost assigned dnschnur Nov 1, 2012

dnschnur added a commit that referenced this pull request Nov 1, 2012

@dnschnur dnschnur referenced this pull request Nov 3, 2012

Closed

Source code hint #825

dnschnur added a commit that referenced this pull request Nov 3, 2012

Updated credits for #851 global variables fix.
Added Szymon Barglowski, who originally reported the fmt variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment