Allow the pie chart to redraw on resize or update. #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the container dimensions were checked only once, which prevented the pie from changing in size as its container was resized.
When a pie's labels don't fit within its container, the pie is redrawn with a smaller radius until the labels fit, or a fixed number of retry attempts are exhausted. The redraw flag was not reset on success, however, which prevented the pie from being redrawn again after a resize or update.
ghost
assigned 
|
This resolves #656; pies can now be resized just like any other plot type. |
dnschnur
added a commit
that referenced
this pull request
Dec 21, 2012
Allow the pie chart to redraw on resize or update.
dnschnur
added a commit
that referenced
this pull request
Dec 21, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of logic bugs that prevented pies from being redrawn.