Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Adding a fix for the inability to set the point lineWidth to 0 #937

Merged
merged 1 commit into from Feb 7, 2013

Conversation

Projects
None yet
2 participants
Contributor

jamiehs commented Jan 20, 2013

This is a bit of a hack taken from issue #842

One option is to set the point lineWidth very low as this patch does, and the other is to set the color to rgba(0,0,0,0). If the alpha option is used, then the point width is still technically set to 0, and the end result is that the shadows are lost. With the way this fix is implemented, the shadows can still be set to either 0 or a higher value.

Hope this is useful!

Adding a fix for the inability to set the point line width to 0. It's…
… a bit of a hack, but it seems like an acceptable workaround.

@ghost ghost assigned dnschnur Feb 7, 2013

dnschnur added a commit that referenced this pull request Feb 7, 2013

Merge pull request #937 from jamiehs/issue-842-cherry-pick
Fix inability to set the point lineWidth to 0.

@dnschnur dnschnur merged commit ad823de into flot:master Feb 7, 2013

Owner

dnschnur commented Feb 7, 2013

This is a bit of a hack, but I think it makes sense to include until we can come up with something better, and I like the fact that you've labeled it clearly. Thanks for your submission!

dnschnur added a commit that referenced this pull request Feb 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment