Generate Pixmap on Sprite::new #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flother hi, a friendly ping - let me know if anything else is needed here and in other PRs. Thanks!! |
|
Sorry for the radio silence. The free time I have to spend on open-source tends to come in waves, all dependent on what life throws at me. I hope I'll have some time in the coming week to take a look at the open PRs here |
|
Looks like merging #72 has caused a trivial conflict. Could you take a quick look? |
|
fixed |
|
More conflicts now #71 has been merged (sorry, should have waited on that before asking you to resolve the earlier conflicts) |
This is a partial simplification from the other PR, without any breaking changes.
I am NOT certain if this is correct logically - please take a look: Currently, sprites are iterated by key, so it goes in sorted order (due to it being a `BTreeMap`). I changed it to iteration over pixmaps - so now `items` have a different order. It seems to be ok, because the `pack_into_po2` seem to resort them according to the largest first anyway, but I am not as familiar with the algo. Also, a minor code de-duplication and spelling fix
Make Sprite a readonly struct, with the Pixmap loading on creation.
|
fixed |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until #72 is merged - this PR includes code from that
Make Sprite a readonly struct, with the Pixmap loading on creation.
This paves a way for simpler and quicker sprites because Sprite is now guaranteed to be valid if passed anywhere.
Also, I suspect the
make_uniquecan be simplified to use Pixmap values instead of converting them temporarily into PNGs