$_ENV dependency on fEmail::setFQDN() #110

Open
jeffturcotte opened this Issue Jul 11, 2012 · 0 comments

Projects

None yet

1 participant

@jeffturcotte
Member

Ticket #729 by pgarcia

As you can see in the php.ini part below, the $_ENV superglobal is not recommended for production servers.

; This directive determines which super global arrays are registered when PHP
; starts up. If the register_globals directive is enabled, it also determines
; what order variables are populated into the global space. G,P,C,E & S are
; abbreviations for the following respective super globals: GET, POST, COOKIE,
; ENV and SERVER. There is a performance penalty paid for the registration of
; these arrays and because ENV is not as commonly used as the others, ENV is
; is not recommended on productions servers. You can still get access to
; the environment variables through getenv() should you need to.
; Default Value: "EGPCS"
; Development Value: "GPCS"
; Production Value: "GPCS";
; http://www.php.net/manual/en/ini.core.php#ini.variables-order
variables_order = "GPCS"

So, to avoid the need to change some settings in the server config, I think that the fEmail class should have some method that could be called to set the desired EHLO FQDN, something like:

$email->setFQDN('sample.com');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment