fValidation::setCSRFTokenField(), allow dashes in HTML attributes #49

Closed
wants to merge 25 commits into
from

Projects

None yet

4 participants

@Tatsh
Tatsh commented Apr 27, 2012

Please let me know if something is missing here and I will fix it.

Tatsh and others added some commits Apr 27, 2012
Tatsh Added ::setCSRFTokenField() abd4e4e
Tatsh Allow dashes in HTML attributes (HTML 5) 2816a5e
Tatsh Fix variable name 2c3136e
Tatsh Fix checking CSRF token 14fe18d
Tatsh Only check if there is a value set 2f492b8
Tatsh Add makeLinks() method to retrieve HTML instead of printing it 47569c2
Tatsh Make method protected f6dd23f
@jeffturcotte jeffturcotte Fixed an issue in fImage::getImageType where too few bytes were read …
…for certain JPEG image types
33f41c3
@jeffturcotte jeffturcotte Fixed return bug in checkConditionalRules f13fa9e
Kevin Hamer Changes to fFile to better handle text filetype detection
Improved the comment

Changes to fFile to better handle text filetype detection

Improved the comment
c81654a
@jeffturcotte jeffturcotte Merge pull request #1 from khamer/master
Changes to fFile to better handle text filetype detection
02eb9ae
Kevin Hamer Updated comment 5b25a75
Kevin Hamer Merge pull request #3 from khamer/master
Forgot comment
384b98a
@jeffturcotte jeffturcotte Added enhancement for registering static fActiveRecord methods. PHP 5…
….3+ only.
3e1fd3d
Kevin Hamer Merge pull request #2 from jeffturcotte/master
Added fORM::registerActiveRecordStaticMethod for "static plugin" support
aa58283
@mattsah mattsah Fix for parsing Accept headers with excess whitespace
This problem is mainly caused by some crazy accept header that's
sent 50% of the time in IE, but it may be caused by other
browsers that add additional whitespace. Not sure if the standard
is clear on whether extra whitespace can or can't exist, but
either way this solves it for non-compliant browsers.
3f6885a
Kevin Hamer Merge pull request #5 from mattsah/master
Fix for parsing Accept headers with excess whitespace
50dcedb
@Tatsh Tatsh Remove default -colorspace argument e2a9f26
@Tatsh Tatsh Detect old version of ImageMagick and use old format if necessary; ad…
…just to new version of ImageMagick syntax which defaults to sRGB by default; detect original colorspace in JPEGs and TIFF images
3b112c5
@Tatsh Tatsh Forgot check for Windows 492bbe2
@jeffturcotte jeffturcotte Added getRootPath to fTemplating 06930e1
@Tatsh Tatsh Resolve merge conflict 5c98c39
@Tatsh Tatsh Resolve merge conflicts c3541d0
@Tatsh Tatsh Add method to get the HTML of the links 6cff56f
@Tatsh Tatsh Forgot to register method 9afbd32
@wbond
Member
wbond commented Nov 21, 2012

So for pull requests to work out, I think you need to create a branch for the specific issue you want pulled, otherwise every commit to your branch gets added to the pull request and it gets overwhelming like here.

So, if you can move this commit to a separate branch and open a pull request on it then I can go through and be sure about what you are asking to merge in.

@wbond wbond closed this Nov 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment