[ignore] Fix add param array type
#2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A developer should be able to do: ```js const paths: string[] = ['.abc/*', '!.abc/d/'] ign.add(paths) ``` However, the type annotation `Array<(string | Ignore)>` doesn't allow it, use `$ReadOnlyArray` instead so that Flow doesn't complain. Check the documentation for `$ReadOnlyArray` for an explanation.
reyronald
changed the title
add and filter param array typesadd param array type
AndrewSouthpaw
requested changes
Sep 7, 2018
|
Done! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A developer should be able to do:
However, the type annotation
Array<(string | Ignore)>doesn't allow it,use
$ReadOnlyArrayinstead so that Flow doesn't complain. Check thedocumentation for
$ReadOnlyArrayfor an explanation./cc @kaelzhang