Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redux_v3-4] Fix errors #3223

Merged
merged 2 commits into from Mar 25, 2019

Conversation

Projects
None yet
2 participants
@retyui
Copy link
Contributor

commented Mar 22, 2019


Other notes:

When we run node cli/dist/cli.js run-tests redux_v4 a command
You will see more error about:

  • deprecated $Subtype
  • Object is any
@retyui

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

What was changed:

-declare export type Dispatch<A: { type: $Subtype<string> }> = DispatchAPI<A>;
+declare export type Dispatch<A: { type: * }> = DispatchAPI<A>;

link to code


-declare export function combineReducers<O: Object, A>(reducers: O):
+declare export function combineReducers<O: {}, A>(reducers: O):

lint to code

@retyui retyui changed the title Fix redux errors [redux_v4] Fix errors Mar 22, 2019

@retyui retyui changed the title [redux_v4] Fix errors [redux_v3-4] Fix errors Mar 22, 2019

@AndrewSouthpaw
Copy link
Contributor

left a comment

Seems good to me, thanks!

@AndrewSouthpaw AndrewSouthpaw merged commit 2c899a1 into flow-typed:master Mar 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

wgao19 added a commit to wgao19/flow-typed that referenced this pull request Apr 30, 2019

Annotate redux v3 for flow past 0.89
- $Subtype is deprecated after 0.89
- Rest annotations follow flow-typed#3223

pascalduez added a commit that referenced this pull request May 4, 2019

[redux_v3.x.x] Annotate for flow past 0.89 (#3288)
- $Subtype is deprecated after 0.89
- Rest annotations follow #3223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.