Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[express_{v4.x.x,v4.16.x}]: correct `is` method return type on requests #3464

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@EvanHahn
Copy link
Contributor

EvanHahn commented Jul 18, 2019

Other notes: req.is returns a string or false, but we were saying that it returned a boolean, which wasn't quite right.

`req.is` returns a string or `false`, but we were saying that it
returned a `boolean`, which wasn't quite right.

* [Link to documentation][1]
* Link to GitHub or npm: [GitHub][2]
* Type of contribution: fix

[1]: https://expressjs.com/en/4x/api.html#req.is
[2]: https://github.com/expressjs/express
Copy link
Collaborator

pascalduez left a comment

Thanks!

@pascalduez pascalduez merged commit def1ce6 into flow-typed:master Jul 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EvanHahn EvanHahn deleted the EvanHahn:fix-express-request-is branch Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.