Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure a trial project can be restarted #1784

Merged
merged 1 commit into from Mar 9, 2023
Merged

Ensure a trial project can be restarted #1784

merged 1 commit into from Mar 9, 2023

Conversation

knolleary
Copy link
Member

Description

As reported by a FF Cloud user, the guards on startFlows/restartFlows did not take into account whether the project was in trial mode.

This fixes the guards and adds some additional tests around trial mode within the container driver layer.

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@knolleary knolleary requested a review from Pezmc March 9, 2023 10:48
Pezmc
Pezmc approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@Pezmc Pezmc left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this in the last review! Looks good.

Edit: Tests failed for OOM, have restarted them!

@knolleary knolleary merged commit bad3d63 into main Mar 9, 2023
4 checks passed
@knolleary knolleary deleted the fix-trial-project-restart branch March 9, 2023 11:26
@github-actions github-actions bot mentioned this pull request Mar 9, 2023
Merged
11 tasks
knolleary added a commit that referenced this pull request Mar 9, 2023
@knolleary
Merge pull request #1786 from flowforge/backport-1784
ea18a99 
Ensure a trial project can be restarted (backport #1784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pezmc Pezmc Pezmc approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knolleary @Pezmc