playlist + chrome: fullscreen does not enlarge video #359

Closed
blacktrash opened this Issue Apr 22, 2013 · 9 comments

Comments

Projects
None yet
3 participants
@blacktrash
Member

blacktrash commented Apr 22, 2013

Not in all browsers, but at least in Chrome: Click fullscreen when on first frame - in some browsers the video does not scale.

http://demos.flowplayer.org/playlist/scrollable-jquerytools.html (first frame - broken)
vs
http://demos.flowplayer.org/playlist/minimal.html (splash - works)

EDIT: not related to first frame. Certain playlist stylings, like the scrollable example, are "transported" into fullscreen unscaled by Chrome.

@ghost ghost assigned nnarhinen Apr 22, 2013

@blacktrash

This comment has been minimized.

Show comment
Hide comment
@blacktrash

This comment has been minimized.

Show comment
Hide comment
@blacktrash

blacktrash Apr 28, 2013

Member

Seems like a problem in conjunction with scrollable and Chrome - see: http://flowplayer.blacktrash.org/fp5/playlist.html for comparison.
Assigning to me to monitor some more.

Member

blacktrash commented Apr 28, 2013

Seems like a problem in conjunction with scrollable and Chrome - see: http://flowplayer.blacktrash.org/fp5/playlist.html for comparison.
Assigning to me to monitor some more.

@ghost ghost assigned blacktrash Apr 28, 2013

@blacktrash

This comment has been minimized.

Show comment
Hide comment
@blacktrash

blacktrash Apr 29, 2013

Member

In the scrollable example even

.is-fullscreen.flowplayer div.scrollable-wrap {
  display: none !important;
}

has no effect in Chrome.
In theory this seems to require a beforfullscreen event - although not guaranteed to work in practice.
Will implement this with an external scripted playlist - duplicating some of the playlist code. But with the advantage that the playlist can already be shown in a splash state (iOS) too.
@nnarhinen - this sort of raises the RFC whether we should allow fp-playlist outside the player container.

Member

blacktrash commented Apr 29, 2013

In the scrollable example even

.is-fullscreen.flowplayer div.scrollable-wrap {
  display: none !important;
}

has no effect in Chrome.
In theory this seems to require a beforfullscreen event - although not guaranteed to work in practice.
Will implement this with an external scripted playlist - duplicating some of the playlist code. But with the advantage that the playlist can already be shown in a splash state (iOS) too.
@nnarhinen - this sort of raises the RFC whether we should allow fp-playlist outside the player container.

@blacktrash

This comment has been minimized.

Show comment
Hide comment
@blacktrash

blacktrash Apr 29, 2013

Member

See: flowplayer/demos@96e5efd
For now I consider this a Chrome bug.
@nnarhinen - leaving open for above RFC.

Member

blacktrash commented Apr 29, 2013

See: flowplayer/demos@96e5efd
For now I consider this a Chrome bug.
@nnarhinen - leaving open for above RFC.

@nnarhinen

This comment has been minimized.

Show comment
Hide comment
@nnarhinen

nnarhinen May 16, 2013

Member

Please add a reproducable demo for this

Member

nnarhinen commented May 16, 2013

Please add a reproducable demo for this

@nnarhinen

This comment has been minimized.

Show comment
Hide comment
Member

nnarhinen commented May 16, 2013

@blacktrash

This comment has been minimized.

Show comment
Hide comment
@blacktrash

blacktrash May 16, 2013

Member

@nnarhinen - as I said, I deem this a Chrome bug/differing behavior.
If you have time and peace think about whether we should allow "external" playlists, i.e. allow to selected elements on the page to behave like fp-playlist inside the container. Right now, when you encounter this bug/feature, you have to ditch the whole setup you carefully crafted in favour one which also has to duplicate playlist code like what I've done here: flowplayer/demos@96e5efd
It would come at the price of an additional config option - like playlistClass or playlistId, not sure haven't thought this through completely - for a playlist element outside the container, but might prevent deep frustration and code duplication.

Member

blacktrash commented May 16, 2013

@nnarhinen - as I said, I deem this a Chrome bug/differing behavior.
If you have time and peace think about whether we should allow "external" playlists, i.e. allow to selected elements on the page to behave like fp-playlist inside the container. Right now, when you encounter this bug/feature, you have to ditch the whole setup you carefully crafted in favour one which also has to duplicate playlist code like what I've done here: flowplayer/demos@96e5efd
It would come at the price of an additional config option - like playlistClass or playlistId, not sure haven't thought this through completely - for a playlist element outside the container, but might prevent deep frustration and code duplication.

@bbbo

This comment has been minimized.

Show comment
Hide comment
@bbbo

bbbo May 16, 2013

Member

external playlists would definitely offer possibilities and probably
ease page design for many customers.

Member

bbbo commented May 16, 2013

external playlists would definitely offer possibilities and probably
ease page design for many customers.

@blacktrash

This comment has been minimized.

Show comment
Hide comment
@blacktrash

blacktrash Jun 6, 2013

Member

Closing here and migrating external playlist RFC to #443

Member

blacktrash commented Jun 6, 2013

Closing here and migrating external playlist RFC to #443

@blacktrash blacktrash closed this Jun 6, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment