Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for react-router 4 #341

Closed
aaronjensen opened this issue Sep 28, 2016 · 4 comments
Closed

Support for react-router 4 #341

aaronjensen opened this issue Sep 28, 2016 · 4 comments
Labels
enhancement An addition to an existing component incomplete

Comments

@aaronjensen
Copy link
Contributor

It's alpha right now so we may not want it here, but I'm opening this issue to at least share the definitions I have so far for 4.0.0-alpha.3

https://gist.github.com/aaronjensen/48fcfaa0d540805d30fa18114c224f3f

@jeffmo
Copy link
Contributor

jeffmo commented Oct 5, 2016

Nice. flow-typed is pretty strict about the versioning patterns that are allowed, and I think maj.min.ptc-alpha versions aren't currently supported yet -- but we probably could/should support that!

@jeffmo jeffmo added incomplete enhancement An addition to an existing component labels Oct 18, 2016
@jeffmo
Copy link
Contributor

jeffmo commented Oct 18, 2016

Linking this in to #392 to track support for prerelease identifiers

@kouak
Copy link
Contributor

kouak commented Mar 20, 2017

Now that react-router v4 has been released, and react-router v4 definitions were merged (53afdde), this issue could probably be closed.

ping @aaronjensen

@aaronjensen
Copy link
Contributor Author

Works for me, if #714 is the only API change so far then awesome. @jeffmo if you could merge #714 in asap that'd be great, it's a breaking change for the release version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An addition to an existing component incomplete
Projects
None yet
Development

No branches or pull requests

3 participants