Performance improvement: single parser instance #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alari
reviewed
Aug 27, 2021
alari
approved these changes
Aug 27, 2021
build.sbt
Outdated
| "org.typelevel" %%% "cats-free" % catsV | ||
| "org.typelevel" %%% "cats-parse" % catsParseV, | ||
| "org.typelevel" %%% "cats-free" % catsV, | ||
| "org.typelevel" %%% "shapeless3-deriving" % "3.0.1" |
| case Right(value) => value | ||
| case Left(e) => Validated.invalidNec(LexerError[S](e.wrapErr)) | ||
| } | ||
| def fromString[S[_]: Comonad](parser: String => ValidatedNec[ParserError[S], Ast[S]], script: String): ValidatedNec[ParserError[S], Ast[S]] = |
| } | ||
| } | ||
|
|
||
| def natParser[S[_] : LiftParser : Comonad, K[_] : Comonad] |
There was a problem hiding this comment.
Code formatting, braces seem strange
| extends Expr[F](AbilityIdExpr, ability) | ||
| extends Expr[F](AbilityIdExpr, ability) { | ||
|
|
||
| def mapK[K[_]: Comonad](fk: F ~> K): Expr[K] = |
There was a problem hiding this comment.
Maybe better return AbilityIdExpr[K]?
DieMyst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use one parser instance for performance reasons.
Performance was increased both for jvm and js builds.
JVM: from 5-7 seconds to 3 seconds
JS: from >30 seconds to 7 seconds
fixes #250