This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Add a more convenient API for calling aqua functions programmatically #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsartem
reviewed
Dec 22, 2022
packages/fluence-js/src/internal/compilerSupport/v3impl/callFunction.ts
Outdated
Show resolved
Hide resolved
shamsartem
reviewed
Dec 22, 2022
packages/fluence-js/src/internal/compilerSupport/v3impl/callFunction.ts
Outdated
Show resolved
Hide resolved
shamsartem
reviewed
Dec 22, 2022
|
|
||
| const getArgumentTypes = (def: FunctionCallDef) => { | ||
| if (def.arrow.domain.tag !== 'labeledProduct') { | ||
| throw new Error('Should be impossible'); |
There was a problem hiding this comment.
If it should be impossible - maybe no need for this chek? Or if you think that it is possible - maybe a better error message for the user so he knows what he can do if this situation accures
There was a problem hiding this comment.
If I don't check the TS compiler will complain about the missing match case
There was a problem hiding this comment.
I see now. I understand that if this happens - compiler output is wrong right?
There was a problem hiding this comment.
Correct, the compiler output would be wrong.
There was a problem hiding this comment.
Maybe would be still not that bad to say it in error message
shamsartem
suggested changes
Dec 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes DXJ-198