timemark precision #81

morgangiraud opened this Issue Nov 15, 2012 · 0 comments


None yet
3 participants

Hi, first thanks for that module, very handy.

I've been trying to get screenshots of some videos but it happens that the result was not enough precise. I found that TimemarkToSeconds function floors the result of the duration.

this.ffmpegTimemarkToSeconds = function(timemark) {

    // split sec/msec part
    var secParts = parts[2].split('.');

    // add seconds
    secs += parseInt(secParts[0], 10);
'You dont add msec part.'
    return secs;

The problem is that, in the screenshots function you use durationsec to calculate the frame i want so i'm not able to get the last one when i put '100%'

timemarks[i] = (parseInt(timemarks[i], 10) / 100) * meta.durationsec;

Is there any particular reason to drop the milliseconds part in timemarkToSeconds ?

@ghost ghost assigned schaermu Nov 28, 2012

@bencevans bencevans closed this in #209 Mar 1, 2014

@njoyard njoyard removed the WIP label Jul 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment