From 5b661bc771e59bb3129d88c3a284b9b877237136 Mon Sep 17 00:00:00 2001 From: Hiroshi Hatake Date: Thu, 28 Sep 2023 12:51:22 +0900 Subject: [PATCH 1/3] hot-reloading: Add descriptions for Windows Signed-off-by: Hiroshi Hatake --- administration/hot-reload.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/administration/hot-reload.md b/administration/hot-reload.md index 839cfc54d..ddea240a5 100644 --- a/administration/hot-reload.md +++ b/administration/hot-reload.md @@ -39,6 +39,12 @@ For using curl to reload fluent-bit, users must specify an empty request body as $ curl -X POST -d {} localhost:2020/api/v2/reload ``` +For Windows, to represent empty body, users have to use `'{}'` as a body instead of raw `{}`: + +```text +PS> curl -X POST -d '{}' localhost:2020/api/v2/reload +``` + ### Via Signal Hot reloading also can be kicked via `SIGHUP`. @@ -47,5 +53,4 @@ Hot reloading also can be kicked via `SIGHUP`. ## Limitations -The hot reloading feature is currently working on Linux and macOS. Windows is not supported yet. - +The hot reloading feature is currently working on Linux, macOS and Windows. From 77e2aeaea39501a87e9f1e66c52fa21831cfb530 Mon Sep 17 00:00:00 2001 From: Hiroshi Hatake Date: Fri, 6 Oct 2023 08:54:43 +0900 Subject: [PATCH 2/3] Clarify the sentence meaning Co-authored-by: Pat Signed-off-by: Hiroshi Hatake --- administration/hot-reload.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/administration/hot-reload.md b/administration/hot-reload.md index ddea240a5..4547b26f7 100644 --- a/administration/hot-reload.md +++ b/administration/hot-reload.md @@ -39,7 +39,7 @@ For using curl to reload fluent-bit, users must specify an empty request body as $ curl -X POST -d {} localhost:2020/api/v2/reload ``` -For Windows, to represent empty body, users have to use `'{}'` as a body instead of raw `{}`: +On Windows, use `'{}'` to represent an empty body instead of raw `{}`: ```text PS> curl -X POST -d '{}' localhost:2020/api/v2/reload From f00ba703c96a5b12ea925d58092eef6accbf7478 Mon Sep 17 00:00:00 2001 From: Hiroshi Hatake Date: Tue, 10 Oct 2023 12:10:56 +0900 Subject: [PATCH 3/3] hot-reload: Use quoted empty body Signed-off-by: Hiroshi Hatake --- administration/hot-reload.md | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/administration/hot-reload.md b/administration/hot-reload.md index 4547b26f7..cb2044c0d 100644 --- a/administration/hot-reload.md +++ b/administration/hot-reload.md @@ -36,13 +36,7 @@ For using curl to reload fluent-bit, users must specify an empty request body as ```text -$ curl -X POST -d {} localhost:2020/api/v2/reload -``` - -On Windows, use `'{}'` to represent an empty body instead of raw `{}`: - -```text -PS> curl -X POST -d '{}' localhost:2020/api/v2/reload +$ curl -X POST -d '{}' localhost:2020/api/v2/reload ``` ### Via Signal